Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] add support for loadBalancerSourceRanges #408

Merged
merged 4 commits into from
Jan 6, 2020
Merged

[kibana] add support for loadBalancerSourceRanges #408

merged 4 commits into from
Jan 6, 2020

Conversation

ichylinux
Copy link
Contributor

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

jmlrt
jmlrt previously approved these changes Dec 18, 2019
Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ichylinux, thanks for this PR, could you also update the service default values in the https://github.com/elastic/helm-charts/blame/master/kibana/README.md#L82?

@jmlrt
Copy link
Member

jmlrt commented Dec 18, 2019

jenkins test this please

@jmlrt jmlrt added the enhancement New feature or request label Dec 18, 2019
@ichylinux
Copy link
Contributor Author

ichylinux commented Dec 21, 2019

@jmlrt thank you for your review.
i might update README.md with wrong procedure.
i hope this is still a valid pull request.

@jmlrt
Copy link
Member

jmlrt commented Jan 6, 2020

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlrt jmlrt merged commit f4fb799 into elastic:master Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants